Skip to content

fix(NcSettingsSection): remove default h2 margin-top - #5897

Merged
susnux merged 2 commits into
masterfrom
fix/NcSettingsSection--remove-header-top-margin
Aug 2, 2024
Merged

fix(NcSettingsSection): remove default h2 margin-top#5897
susnux merged 2 commits into
masterfrom
fix/NcSettingsSection--remove-header-top-margin

Conversation

@ShGKme

@ShGKme ShGKme commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • NcSettingsSection header has unneeded top margin from global styles
  • NcSettingsSection should only has its own padding around the content

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: settings Related to the settings component labels Aug 2, 2024
@ShGKme ShGKme added this to the 8.15.2 milestone Aug 2, 2024
@ShGKme
ShGKme requested review from Antreesy, Pytal, st3iny and susnux August 2, 2024 09:40
@ShGKme ShGKme self-assigned this Aug 2, 2024
@ShGKme

ShGKme commented Aug 2, 2024

Copy link
Copy Markdown
Contributor Author

/backport to next

ShGKme added 2 commits August 2, 2024 11:41
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
ShGKme force-pushed the fix/NcSettingsSection--remove-header-top-margin branch from dc45b82 to 1698d82 Compare August 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: settings Related to the settings component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants