fix(NcAppNavigation): add border-right - #5953
Merged
Merged
Conversation
marcoambrosini
added
bug
marcoambrosini
changed the title
marcoambrosini
force-pushed
the
feat/add-navigation-border
branch
from
August 13, 2024 12:21
a144340 to
3a5d01b
Compare
susnux
reviewed
Aug 13, 2024
susnux
approved these changes
Aug 14, 2024
Contributor
|
The commit sign-off needs to be fixed, otherwise good! |
Contributor
|
ShGKme
approved these changes
Aug 15, 2024
ShGKme
left a comment
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Better, but for me it makes it even less easy to find the toggle button because not it is visually out of the navigation.
Contributor
|
/backport to next |
Contributor
I think as we overlay the content a shadow might be better suited: Bildschirmaufnahme_20240815_121458.webmBut still this PR makes things lot better :) |
ShGKme
changed the title
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
ShGKme
force-pushed
the
feat/add-navigation-border
branch
from
August 20, 2024 08:39
d562637 to
3bf8bae
Compare
Contributor
|
Fixed DCO and squashed |
Contributor
|
Merge? |
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.