Initial setup for sharing scripts - #18
Draft
AlvaroBrey wants to merge 2 commits into
Draft
Conversation
AlvaroBrey
force-pushed
the
share-scripts-initial
branch
3 times, most recently
from
September 23, 2022 14:44
68d39a9 to
8be8e19
Compare
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
AlvaroBrey
force-pushed
the
share-scripts-initial
branch
from
September 23, 2022 14:49
8be8e19 to
0a1a9f3
Compare
AlvaroBrey
marked this pull request as ready for review
September 23, 2022 14:53
tobiasKaminsky
previously approved these changes
Sep 26, 2022
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
AlvaroBrey
dismissed stale reviews from timkrueger and tobiasKaminsky
via
September 29, 2022 16:01
d3838af
AlvaroBrey
marked this pull request as draft
September 29, 2022 16:02
Member
Author
|
Marked as draft as I have now become aware of two incompatible uses of |
Member
|
If you need help, just ping me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #17
get_branch.shis meant to replacegetBranchName.shandgetBranchBase.sh.This requires some stuff to be setup in the CI environment:
GITHUB_TOKEN: self-explanatory, we should use the default${{ secrets.GITHUB_TOKEN }}on Github, and a PAT on Drone.GITHUB_REPOSITORY: example isnextcloud/android(including org). Can be retrieved from Github's env (${{ github.repository}}) and also Drone's ($DRONE_REPO)These are env variables and not shell arguments because they are intended to be used in code common to all scripts (currently only
lib.sh), so we won't need to pass them around so much.