fix: preserve original Authentication to be swapped later in HaProxy - #334
Merged
Conversation
Member
|
swapping should only takes place when HaProxy is used and there should not be swap when "raw" socket is used. |
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
andrey18106
force-pushed
the
fix/ex-app-proxy/authentication-header-swap
branch
from
July 22, 2024 21:24
8698204 to
d7a86f7
Compare
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
marked this pull request as ready for review
July 23, 2024 09:51
bigcat88
approved these changes
Jul 23, 2024
bigcat88
left a comment
bigcat88
left a comment
Member
There was a problem hiding this comment.
Now this applies only for remote installations(when using https and request to ExApp come throught DSP), regarding changes for docker-socket-proxy is here:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nextcloud/docker-socket-proxy#33