feat: show when task is taking too long - #315
Merged
Merged
Conversation
lukasdotcom
marked this pull request as draft
July 17, 2025 20:17
lukasdotcom
changed the title
lukasdotcom
changed the title
lukasdotcom
marked this pull request as ready for review
July 18, 2025 13:49
lukasdotcom
force-pushed
the
feat/warning-when-not-pickedup
branch
from
July 18, 2025 21:08
5fac587 to
f29dfd0
Compare
janepie
reviewed
Jul 21, 2025
janepie
left a comment
janepie
left a comment
Member
There was a problem hiding this comment.
Looks good!
Some small things:
- in the chat with Context Agent, there may be more than one task happening (text2text, then a tool call, then a new text2text task). When the first task is picked up, the message disappears and doesn't come up again (maybe for 10 minutes or more). Can we either check for other tasks or keep the warning when it once appears until there is a new chat message?
- I'd clarify what "this" is in the message. Maybe
that Assistant is correctly configured? Wdyt? - nitpick: there is an o missing in
tooLongForScheduling
Member
Author
About this. I'm not sure how I can know which task is the one context agent is currently on. I couldn't find a way to see that. Right now it just makes sure that the first context agent task is actually picked up by context agent.
I had been thinking of maybe mentioning the task name instead, but Assistant is probably best.
Fixed in newest commit |
Member
Author
|
Implemented changes like discussed in meeting to not hide warning once it shows up in the chat. |
marcelklehr
reviewed
Jul 23, 2025
lukasdotcom
force-pushed
the
feat/warning-when-not-pickedup
branch
2 times, most recently
from
July 23, 2025 12:07
8a7e222 to
bdb71ec
Compare
julien-nc
requested changes
Aug 1, 2025
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
julien-nc
force-pushed
the
feat/warning-when-not-pickedup
branch
from
August 1, 2025 09:27
bdb71ec to
85dd857
Compare
Member
|
Rebased on main |
Signed-off-by: Lukas Schaefer <lukas@lschaefer.xyz>
lukasdotcom
force-pushed
the
feat/warning-when-not-pickedup
branch
from
August 1, 2025 13:14
28bb3bc to
ac66c27
Compare
|
@janepie @julien-nc @marcelklehr can this be merged? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements easy part of #306
Does some refactoring of assistant.js for the setProgress function to make the change easier
Also updates nextcloud-vue-libraries due to: nextcloud-libraries/nextcloud-vue#7117
Pictures
The warning in a task
In the last commit also added this to the chat. Same behavior of if scheduled for 5 minutes it will show this warning.