Add pulse animation to assistant icon - #360
Conversation
7efcec8 to
a2c11f8
Compare
|
Removed review request as icon size shrunk when I made the viewport bigger, looking for workaround |
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
a2c11f8 to
a485671
Compare
|
Fixed the size issue, ready for review now |
marcelklehr
left a comment
marcelklehr
left a comment
There was a problem hiding this comment.
If an animation is necessary I like this better than the previous proposal. Looks nice :)
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Seems good to go then, right?
@marcoambrosini does it work gracefully when:
- focusing instead of hover
- stopping the hiver befire the animation is done (could just finish the animation)
- staying on hovering (either is fine: only animate once, or repeat as well)
|
@jancborchardt as of now focusing does not trigger the animation. Should I add it? |
|
@marcoambrosini I'd say generally we should treat hover and focus as close as possible, so yes. But it's not a blocker. |
|
Gave it a quick try and this is a bit complex. I will reference in new issue |
github-project-automation
Bot
moved this from 🏗️ At engineering
to 🎉 Done
in 🖍 Design team
|
Do you want to add that to the NcAssistantIcon component of nextcloud/vue as well? |
|
That would result in this animation being in many other places right? I think it would be better to avoid that for now |
4 participants
fix #359
Screen.Recording.2025-09-17.at.09.39.17.mov