Skip to content

fix(ui): set min-height on modal to prevent size jump - #371

Merged
janepie merged 1 commit into
nextcloud:mainfrom
cnaples79:fix-modal-jump
Oct 10, 2025
Merged

fix(ui): set min-height on modal to prevent size jump#371
janepie merged 1 commit into
nextcloud:mainfrom
cnaples79:fix-modal-jump

Conversation

@cnaples79

Copy link
Copy Markdown
Contributor

Summary

This PR fixes an issue where the Assistant modal "jumps" in size when it's opened, before the content is loaded. This was caused by the modal not having a defined height until the content was rendered.

Changes Made

  • Added a min-height of 500px to the .assistant-modal--content class in src/components/AssistantTextProcessingModal.vue. This ensures that the modal has a consistent height from the moment it is rendered, preventing the jarring size change.

Test Plan

  • I ran npm run build to ensure the code builds successfully.
  • I also ran npm run lint and npm run stylelint to ensure the changes are consistent with the project's coding style.
  • Manual testing:
    1. Open the assistant modal.
    2. Verify that the modal appears at its final size and does not resize when the content loads.

Fixes #370

Signed-off-by: Chase Naples <Cnaples79@gmail.com>

@janepie janepie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, thanks a lot!

@cnaples79

Copy link
Copy Markdown
Contributor Author

@janepie you're welcome! happy to help.

@janepie
janepie merged commit f4108c5 into nextcloud:main Oct 10, 2025
9 checks passed
@janepie

janepie commented Oct 15, 2025

Copy link
Copy Markdown
Member

Hey @cnaples79
We have a Nextcloud Talk instance where we invite Nextcloud contributors to be able to communicate more quickly, and we also have team channels for e.g. "Integrations" (incl. AI topics). If you like, I could give you a guest account via the email address in your commits?

@cnaples79

Copy link
Copy Markdown
Contributor Author

@janepie Sure, that sounds great! I'd be happy to help contribute more.

@janepie janepie mentioned this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assistant modal opened from the top bar icon jumps from a small modal to a large one

2 participants