fix(ui): set min-height on modal to prevent size jump - #371
Merged
Conversation
Signed-off-by: Chase Naples <Cnaples79@gmail.com>
cnaples79
force-pushed
the
fix-modal-jump
branch
from
October 8, 2025 21:02
ccc9be9 to
4dcea4e
Compare
janepie
approved these changes
Oct 9, 2025
janepie
left a comment
Member
There was a problem hiding this comment.
Works as intended, thanks a lot!
Contributor
Author
|
@janepie you're welcome! happy to help. |
Member
|
Hey @cnaples79 |
Contributor
Author
|
@janepie Sure, that sounds great! I'd be happy to help contribute more. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the Assistant modal "jumps" in size when it's opened, before the content is loaded. This was caused by the modal not having a defined height until the content was rendered.
Changes Made
min-heightof500pxto the.assistant-modal--contentclass insrc/components/AssistantTextProcessingModal.vue. This ensures that the modal has a consistent height from the moment it is rendered, preventing the jarring size change.Test Plan
npm run buildto ensure the code builds successfully.npm run lintandnpm run stylelintto ensure the changes are consistent with the project's coding style.Fixes #370