Check if ContextAgentInteraction exists - #378
Merged
Merged
Conversation
Member
|
Can we remove these from the psalm blacklist if this is fixed or do we still need these entries? Would be nice to get the insights if we're using classes without checking if the exist first: https://github.com/nextcloud/assistant/blob/main/psalm.xml#L38-L43 |
julien-nc
force-pushed
the
fix/377/check-ContextAgentInteraction-exists
branch
from
October 13, 2025 13:36
4d01f27 to
fc45682
Compare
…cking if we just received a response for an agency confirmation Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/377/check-ContextAgentInteraction-exists
branch
from
October 14, 2025 09:24
fc45682 to
f7124d4
Compare
Member
Author
|
@marcelklehr I removed |
julien-nc
force-pushed
the
fix/377/check-ContextAgentInteraction-exists
branch
2 times, most recently
from
October 14, 2025 15:46
51c2bb2 to
b02a3f5
Compare
…laces we are sure it's fine Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/377/check-ContextAgentInteraction-exists
branch
from
October 14, 2025 17:08
b02a3f5 to
1b7640c
Compare
Member
Author
|
@marcelklehr Weirdly enough, Psalm is not aware of the class_exist check later in the same boolean expression. We need to isolate the check in a wrapping if. See vimeo/psalm#7980 |
marcelklehr
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before using it when checking if we just received a response for an agency confirmation.
This prevents the assistant to work in NC 30.
I checked if the same mistake was made with ContextAgentInteraction or ContextAgentAudioInteraction somewhere else, looks good.
closes #377