Appointments Slot Support by miaulalala · Pull Request #3470 · nextcloud/calendar

miaulalala · 2021-09-13T09:03:04Z

This brings all the basics of #1023

Fixes #3482
Fixes #3478
Fixes #3481
Fixes #3477

Todo

Add a unique index on the appointment config token
Add start and end date
rename buffer field to be more self explanatory
change from minutes to seconds for interval, length, ...

st3iny

I think the date range field is missing from the API (ref #1023 (comment)).

st3iny · 2021-11-05T15:10:25Z

CRUD UI for configs is live for testing.

codecov · 2021-11-24T14:17:37Z

Codecov Report

Merging #3470 (571b093) into master (84d7011) will increase coverage by 2.10%.
The diff coverage is 0.50%.

❗ Current head 571b093 differs from pull request most recent head 87e8586. Consider uploading reports for the commit 87e8586 to get more accurate results

@@             Coverage Diff              @@
##             master    #3470      +/-   ##
============================================
+ Coverage     27.70%   29.80%   +2.10%     
- Complexity      123      309     +186     
============================================
  Files           165      219      +54     
  Lines          6018     7278    +1260     
  Branches        877      907      +30     
============================================
+ Hits           1667     2169     +502     
- Misses         4351     5109     +758

Flag	Coverage Δ
javascript	`20.90% <0.50%> (-1.44%)`	⬇️
php	`70.22% <ø> (-24.40%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/appointments/main-booking.js	`0.00% <0.00%> (ø)`
src/appointments/main-confirmation.js	`0.00% <0.00%> (ø)`
src/appointments/main-conflict.js	`0.00% <0.00%> (ø)`
src/appointments/main-overview.js	`0.00% <0.00%> (ø)`
...components/AppNavigation/AppointmentConfigList.vue	`0.00% <0.00%> (ø)`
...ppointmentConfigList/AppointmentConfigListItem.vue	`0.00% <0.00%> (ø)`
...onents/AppNavigation/Settings/ShortcutOverview.vue	`0.00% <ø> (ø)`
src/components/AppointmentConfigModal.vue	`0.00% <0.00%> (ø)`
...s/AppointmentConfigModal/CheckedDurationSelect.vue	`0.00% <0.00%> (ø)`
...components/AppointmentConfigModal/Confirmation.vue	`0.00% <0.00%> (ø)`
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d7011...87e8586. Read the comment docs.

Signed-off-by: Anna Larch <anna@nextcloud.com>

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Signed-off-by: Anna Larch <anna@nextcloud.com>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Signed-off-by: Anna Larch <anna@nextcloud.com>

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst

Works as expected 👍 🎊

miaulalala · 2021-11-25T15:22:45Z

For me too.

miaulalala added 2. developing Work in progress enhancement New feature request labels Sep 13, 2021

miaulalala self-assigned this Sep 13, 2021

ChristophWurst reviewed Sep 13, 2021

View reviewed changes

Comment thread tests/php/unit/Controller/AppointmentsControllerTest.php Outdated

ChristophWurst reviewed Sep 13, 2021

View reviewed changes

Comment thread lib/Db/Appointment.php Outdated

miaulalala mentioned this pull request Sep 15, 2021

Provide appointment slots for a given time span via REST API #3477

Closed

ChristophWurst reviewed Sep 30, 2021

View reviewed changes

Comment thread composer.json Outdated

st3iny reviewed Oct 22, 2021

View reviewed changes

ChristophWurst marked this pull request as draft October 27, 2021 12:17

ChristophWurst reviewed Oct 27, 2021

View reviewed changes

Comment thread composer.json Outdated

tcitworld reviewed Nov 2, 2021

View reviewed changes

Comment thread lib/Profile/AppointmentsAction.php Outdated

Comment thread lib/Profile/AppointmentsAction.php Outdated

st3iny reviewed Nov 2, 2021

View reviewed changes

Comment thread lib/Db/AppointmentConfig.php

st3iny reviewed Nov 2, 2021

View reviewed changes

Comment thread lib/Migration/Version2040Date20210908101001.php

st3iny reviewed Nov 5, 2021

View reviewed changes

Comment thread lib/Db/AppointmentConfig.php

ChristophWurst added this to the v3.0.0 milestone Nov 9, 2021

st3iny reviewed Nov 23, 2021

View reviewed changes

Comment thread lib/Controller/AppointmentConfigController.php Outdated

ChristophWurst force-pushed the enhancement/appointments branch 2 times, most recently from b910721 to a2d6467 Compare November 24, 2021 13:15

nextcloud deleted a comment from codecov Bot Nov 24, 2021

ChristophWurst marked this pull request as ready for review November 24, 2021 14:21

ChristophWurst requested review from ChristophWurst, GretaD, st3iny and tcitworld November 24, 2021 14:21

ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 24, 2021

ChristophWurst assigned ChristophWurst and unassigned miaulalala Nov 24, 2021

miaulalala and others added 25 commits November 25, 2021 16:06

Add booking mechanism for apptments

9b21971

Signed-off-by: Anna Larch <anna@nextcloud.com>

Improve appointment slot booking modal

741be6c

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>

Add interval logic

3fe1fe7

Signed-off-by: Anna Larch <anna@nextcloud.com>

Removed times 60 multiplier for appointments

34743db

Signed-off-by: Anna Larch <anna@nextcloud.com>

Modify data structure of availability

fdac005

Signed-off-by: Anna Larch <anna@nextcloud.com>

Format code

8c63dc0

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Add appointments availability settings

3d29295

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Set the time zone on availability start and end time stamps

233aadf

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix time before next slot

50393bb

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Filter appointment configs on a db level

a10fc3d

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Use routes via name

0364647

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Drop dead code

09ddffb

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Drop invalid visibility option

7cd7424

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Drop dead code

69d6225

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Drop dead code

8d71b79

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Drop php7.2 remnants

ed407fa

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix tests

26e40b6

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Catch null HTTP status

8812eb7

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fix wrong identifier for the target calendar

c5bdbd4

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Persist the calendar URI for an appointment config

355ebe2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Track calendars by their unique URL

f78e133

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Sort appointment configs by their name

85c80ca

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Change rounding logic to use interval instead of lenght

5086187

Signed-off-by: Anna Larch <anna@nextcloud.com>

Delete appointment configs when the user is deleted

f88e39f

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

Fetch the appointment availability default from caldav, if possible

87e8586

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

ChristophWurst force-pushed the enhancement/appointments branch from 571b093 to 87e8586 Compare November 25, 2021 15:06

ChristophWurst approved these changes Nov 25, 2021

View reviewed changes

miaulalala merged commit 0b667ea into master Nov 25, 2021

delete-merged-branch Bot deleted the enhancement/appointments branch November 25, 2021 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Appointments Slot Support - #3470

Appointments Slot Support#3470
miaulalala merged 55 commits into
masterfrom
enhancement/appointments

miaulalala commented Sep 13, 2021 •

edited by ChristophWurst

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

st3iny left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

st3iny commented Nov 5, 2021 •

edited

Loading

Uh oh!

Uh oh!

codecov Bot commented Nov 24, 2021 •

edited

Loading

Uh oh!

ChristophWurst left a comment

Uh oh!

miaulalala commented Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

miaulalala commented Sep 13, 2021 • edited by ChristophWurst Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

st3iny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

st3iny commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Nov 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

miaulalala commented Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miaulalala commented Sep 13, 2021 •

edited by ChristophWurst

Loading

st3iny commented Nov 5, 2021 •

edited

Loading

codecov Bot commented Nov 24, 2021 •

edited

Loading