Resize maximum dimensions for pictures coming from SocialApiService - #2745
Merged
Conversation
tcitworld
requested review from
ChristophWurst,
call-me-matt,
eleith,
juliusknorr and
miaulalala
May 16, 2022 17:48
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
=============================================
+ Coverage 18.04% 68.76% +50.72%
- Complexity 247 251 +4
=============================================
Files 97 22 -75
Lines 3170 714 -2456
Branches 439 0 -439
=============================================
- Hits 572 491 -81
+ Misses 2405 223 -2182
+ Partials 193 0 -193 Continue to review full report at Codecov.
|
tcitworld
force-pushed
the
resize-pictures-from-social-api-service
branch
2 times, most recently
from
May 16, 2022 18:01
4ef3551 to
0a4d8d5
Compare
ChristophWurst
approved these changes
May 16, 2022
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
You get bonus points for declare(strict_types=1); ;-)
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
resize-pictures-from-social-api-service
branch
from
May 16, 2022 18:10
0a4d8d5 to
b6dd2e3
Compare
Member
|
But I am not sure it closes #2743 completely - |
juliusknorr
approved these changes
May 17, 2022
Member
|
/backport to stable4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2743
Make sure every picture fetched from SocialAPIService has a maximum size of 256 pixels.
Should we add an extra condition to reject on size being to high?
Would be nice to test ImageResizer with a few test pictures too.