refactor: Fix psalm issues - #7258
Merged
Merged
Conversation
CarlSchwan
force-pushed
the
carl/psalm
branch
4 times, most recently
from
September 24, 2025 07:36
1c59e89 to
51ce6bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
CarlSchwan
force-pushed
the
carl/psalm
branch
from
September 24, 2025 08:44
51ce6bb to
79999b3
Compare
come-nc
approved these changes
Sep 27, 2025
CarlSchwan
force-pushed
the
carl/psalm
branch
2 times, most recently
from
September 28, 2025 09:44
290c346 to
81c8820
Compare
CarlSchwan
marked this pull request as ready for review
September 28, 2025 09:44
CarlSchwan
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
September 28, 2025 09:44
- Add typing for most of the services, controllers and mappers - Add api doc for mappers - Use vendor-bin for psalm - Use attributes for controllers - Fix upload of attachments Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/psalm
branch
from
September 28, 2025 09:49
81c8820 to
5cf4861
Compare
Member
Author
|
cypress test also crash on main so not an issue introduced by this PR |
luka-nextcloud
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist