feature addition: [user_ldap] update user profile from LDAP - #9614
Merged
Conversation
march42
force-pushed
the
feature/ldap_update_profile
branch
2 times, most recently
from
March 7, 2023 19:14
3496297 to
0c197a7
Compare
6 tasks
march42
commented
Mar 8, 2023
come-nc
reviewed
Apr 4, 2023
5 tasks
march42
force-pushed
the
feature/ldap_update_profile
branch
from
April 29, 2023 15:04
f7ba832 to
fb64813
Compare
Contributor
Author
Do you think it's okay or did I miss something? @come-nc |
come-nc
approved these changes
May 15, 2023
Contributor
I think it’s good, could you try rebasing on master to see if it helps with CI? |
* feature addition: [user_ldap] update user profile from LDAP * added Fediverse field explanation * clearification of user profile data handling * data handling on profile update in user_ldap * being more specific about the data corrected some misformatted parts * better handling of user profile changes * removed profile data from LDAP will get removed Signed-off-by: Marc Hefter <marchefter@gmail.com>
march42
force-pushed
the
feature/ldap_update_profile
branch
from
May 16, 2023 08:03
fb64813 to
eeb14ed
Compare
Contributor
Author
Done. And it now shows 'This workflow requires approval from a maintainer.' |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
|
Thank you for your contribution and patience 💙 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated documentation for feature addition issue 32085
corresponding PR for server
Added screenshot of additional section in LDAP/AD advanced tab.
Added explanations of LDAP/AD attribute settings and handling.