[stable31] Adjust saving annotations in public pages to changes in Nextcloud 31 - #1150
Merged
Conversation
@nextcloud/sharing was already an implicit dependency, but now it is made explicit to use the functions it provides in the PDF viewer code. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
In Nextcloud 31 the "sharingToken" element that was used to know the token of the share was removed and replaced with data provided by the initial state API. However, rather than directly getting the value using the initial state API, the token is now got using the @nextcloud/sharing library, which is expected to handle any future change. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Member
Author
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
deleted the
backport/1149/stable31-adjust-saving-annotations-in-public-pages-to-changes-in-nextcloud-31
branch
February 20, 2025 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1149