fix pdfviewer on public pages - #655
Merged
Merged
Conversation
szaimen
requested review from
a team,
PVince81,
Pytal,
artonge and
jancborchardt
and removed request for
a team
September 7, 2022 08:59
szaimen
marked this pull request as ready for review
September 7, 2022 09:00
Collaborator
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
enh/noid/fix-public-pages
branch
from
September 7, 2022 09:01
5588d81 to
7f51ac4
Compare
danxuliu
previously requested changes
Sep 7, 2022
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
The bottom of the PDF viewer overflows the window, because the minimum height of the content is set to 100%. However, with the new style it seems that the minimum height must take into account the height of the header, so it should be calc(100% - 50px) (or something similar) instead.
Besides that please note that this may need to be adjusted again once nextcloud/server#33803 is fixed.
2 tasks
szaimen
force-pushed
the
enh/noid/fix-public-pages
branch
from
September 8, 2022 09:56
7f51ac4 to
4d56a26
Compare
Collaborator
Author
|
/compile amend / |
Collaborator
Author
done |
Signed-off-by: szaimen <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/noid/fix-public-pages
branch
from
September 8, 2022 10:02
4d56a26 to
962e73f
Compare
skjnldsv
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close nextcloud/server#33871
Signed-off-by: szaimen szaimen@e.mail.de