Add public link logic by artonge · Pull Request #1278 · nextcloud/photos

artonge · 2022-09-21T14:51:17Z

✔️ To review

artonge · 2022-09-22T14:04:58Z

/backport to stable25

artonge · 2022-09-29T08:21:36Z

Important changes I made after realizing that I didn't test without being logged in…

Added a /dav/photospublic/{token} endpoint to not have conflict with /dav/photos/{user}
5b0a3a9#diff-445ce42266f69bcf9d421f81e31170379e803befd4eddd72851cd99ddc91a56cR34-R87
Intercept webdav request in the backend to authenticate public access with a token
Listener: https://github.com/nextcloud/photos/pull/1278/files#diff-213bbab031403681106d94580acb181d9cde8a708293283a9e620b542c390d8c
And auth backend: 5b0a3a9#diff-5464ecee14465d8a62cbbd7926c8b83b7667752403a7d58098a816f925a52bc5R58-R74
For that, I needed to add type authentication in info.xml to intercept them early enough
https://github.com/nextcloud/photos/pull/1278/files#diff-ab97a56738913a50d2334c4d3f10991748d3e29d011f5a674734b63d33d5ce9eR15

@PVince81 can you validate the approach ?

Signed-off-by: Louis Chemineau <louis@chmn.me>

As there is nothing to separate for public album Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: Louis Chemineau <louis@chmn.me>

This reverts commit 2de383f. Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added 2. developing Work in progress feature: albums Related to the albums section labels Sep 21, 2022

artonge added this to the Nextcloud 25 milestone Sep 21, 2022

artonge self-assigned this Sep 21, 2022

blizzz mentioned this pull request Sep 22, 2022

25.0.0 RC 1 nextcloud/server#34185

Merged

2 tasks

artonge force-pushed the feat/public_album branch from b482d8e to 1b2462a Compare September 22, 2022 10:01

blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022

artonge modified the milestones: Nextcloud 26, Nextcloud 25 Sep 22, 2022

artonge commented Sep 22, 2022

View reviewed changes

Comment thread lib/Album/AlbumMapper.php

artonge commented Sep 22, 2022

View reviewed changes

Comment thread lib/Sabre/Album/PublicAlbumRoot.php Outdated

CarlSchwan reviewed Sep 22, 2022

View reviewed changes

Comment thread lib/Controller/PublicAlbumController.php Outdated

Comment thread lib/Controller/PublicAlbumController.php Outdated

Comment thread lib/Service/UserConfigService.php Outdated

Comment thread src/PhotosPublic.vue Outdated

artonge commented Sep 22, 2022

View reviewed changes

blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022

artonge force-pushed the feat/public_album branch from a350154 to 69bd59f Compare September 26, 2022 10:06

artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 26, 2022

artonge force-pushed the feat/public_album branch from bf37aaa to 4291240 Compare September 26, 2022 16:21

artonge requested a review from skjnldsv September 26, 2022 16:22