fix(a11y): Return focus to Add button on dialog close - #2231
Merged
Conversation
Pytal
added
bug
Pytal
requested review from
JuliaKirschenheuter,
ShGKme,
artonge and
emoral435
January 4, 2024 01:00
Member
Author
This comment was marked as outdated.
This comment was marked as outdated.
backportbot-nextcloud
Bot
added
the
backport-request
artonge
approved these changes
Jan 4, 2024
emoral435
approved these changes
Jan 4, 2024
Pytal
force-pushed
the
fix/a11y/new-album-return-focus
branch
from
January 4, 2024 23:30
3966224 to
e75e1f8
Compare
Contributor
|
NcVue is released and bumped, we can merge this PR |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/a11y/new-album-return-focus
branch
from
January 24, 2024 18:12
e75e1f8 to
5e9efe1
Compare
Member
Author
|
/compile |
Pytal
added
4. to release
Pytal
marked this pull request as ready for review
January 24, 2024 18:13
Pytal
enabled auto-merge
January 24, 2024 18:14
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
1 task
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs feat(NcModal): Set return focus element on focus trap deactivation nextcloud-libraries/nextcloud-vue#5025
Fix [BITV] 9.2.4.3/4.2 - When the "Create new album" dialog is closed using the "Close" button, the keyboard focus does not return to the "Add" button but is instead moved to the beginning of the page. (1) server#41878