[stable33] Fix downloading files from public share - #3506
Merged
Conversation
backportbot
Bot
added
bug
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "public.php/dav" endpoint from server is not compatible with the tokens used for public albums by the Photos app, but they work fine with the "remote.php/dav" endpoint. By default @nextcloud/files/dav uses "public.php/dav" for remote URLs in public pages, so they need to be explicitly replaced with "remote.php/dav" (which is the one already used for non public pages, so it is fine to use it unconditionally). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/3476/stable33
branch
from
May 6, 2026 23:53
ff650c0 to
c7f6e1f
Compare
Member
|
/compile / |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
danxuliu
marked this pull request as ready for review
May 7, 2026 00:41
danxuliu
approved these changes
May 7, 2026
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍
Cypress is failing hard, although it should™ be unrelated 🤔
Member
It is indeed unrelated. The snapshots show |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3476