cleanup filecache database handling a bit - #10921
Closed
icewind1991 wants to merge 2 commits into
Closed
Conversation
MorrisJobke
reviewed
Aug 30, 2018
icewind1991
force-pushed
the
cache-db-cleanup
branch
from
September 12, 2018 15:16
16527db to
f01f894
Compare
rullzer
force-pushed
the
cache-db-cleanup
branch
2 times, most recently
from
October 2, 2018 17:38
7ffe66c to
caa096c
Compare
MorrisJobke
approved these changes
Oct 2, 2018
MorrisJobke
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍 Code change looks also good
Member
|
Phan is not happy |
icewind1991
force-pushed
the
cache-db-cleanup
branch
2 times, most recently
from
October 17, 2018 15:04
a3923d9 to
f3c5809
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
…n checker Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
cache-db-cleanup
branch
from
October 18, 2018 14:24
f3c5809 to
a580b97
Compare
Member
|
Phan is still not happy :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move building queries as string over to the query builder