Skip to content

Add back the total used space per user - #11417

Merged
skjnldsv merged 4 commits into
masterfrom
hover-quota-used-space-regression
Sep 28, 2018
Merged

Add back the total used space per user#11417
skjnldsv merged 4 commits into
masterfrom
hover-quota-used-space-regression

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Fix #11217

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@JSoko JSoko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works, thank You!

@rullzer

rullzer commented Sep 27, 2018

Copy link
Copy Markdown
Member

CI not happy

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Can be merged once CI is happy

@JSoko

JSoko commented Sep 28, 2018

Copy link
Copy Markdown
Member

One small thing:
For users who use 0kb ist shows "unknown Space used"
Bug or feauture?
grafik

@skjnldsv

Copy link
Copy Markdown
Member Author

@JSoko feature. The user did not logged in yet so the user folder doesn't exists.
Though I can say it's better for the user to see 0kb used even if it's not really true :)

I'll change this!

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsv merged commit ecf33a6 into master Sep 28, 2018
@skjnldsv
skjnldsv deleted the hover-quota-used-space-regression branch September 28, 2018 06:59
@skjnldsv

Copy link
Copy Markdown
Member Author

Backport on #11425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants