log version number in each log line

[MorrisJobke]

Makes it a lot easier to analyze log files, because then you see if the log was fixed with a recent version or was caused by a recent version for example.

cc @nickvergessen @LukasReschke @schiessle @blizzz

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @bartv2 and @MTGap to be potential reviewers

[LukasReschke]

Good stuff :)

[LukasReschke]

LGTM

[blizzz]

Personally, I don't like it, it's an excuse for doing proper bug reports. If version is missing, then other necessary information is probably missing, too, and you'd need to ask for other stuff anyway. ±0

[LukasReschke]

Personally, I don't like it, it's an excuse for doing proper bug reports. If version is missing, then other necessary information is probably missing, too, and you'd need to ask for other stuff anyway.

It's also helpful in case you want to quickly take a look in your log monitoring systems when an error appeared and on what versions :)

… not really super awesome to always have to look up when one updated etc…

[nickvergessen]

I can see the point, but I don't really like to invoke yet another class when writing a log.

[LukasReschke]

I can see the point, but I don't really like to invoke yet another class when writing a log.

IConfig is already used in that function, maybe manually read from the config version?

[MorrisJobke]

I can see the point, but I don't really like to invoke yet another class when writing a log.

I also checked it and all it does it reads the current session. And the version is loaded anyways before. I feared also to add another dependency there, but it would really help to make looking at logs easy - especially when doing upgrade testing.

[MorrisJobke]

@blizzz @nickvergessen Yes or no? I would love to see this included.

[MorrisJobke]

Maybe others also have an opinion on this? @schiessle @rullzer @icewind1991

[nickvergessen]

I'm okay, when we use $config->getValue('version') so no session stuff is called, etc.

[MorrisJobke]

I'm okay, when we use $config->getValue('version') so no session stuff is called, etc.

Done :)

[nickvergessen]

👍

[MorrisJobke]

stable10: #1646
stable9: #1647