confirm auth on share generated by Circles - #18235
Merged
Merged
Conversation
Member
Author
|
late, but would be nice to have this implemented in NC18. Allows using the Circles ShareProvider to check validity of Token used during federated shares. Love. |
ArtificialOwl
force-pushed
the
enh/noid/federated-on-circles
branch
from
December 5, 2019 16:40
252fb61 to
1065f58
Compare
blizzz
approved these changes
Dec 13, 2019
Signed-off-by: Maxence Lange <maxence@artificial-owl.com> returns true Signed-off-by: Maxence Lange <maxence@artificial-owl.com> DI Signed-off-by: Maxence Lange <maxence@artificial-owl.com> DI Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
enh/noid/federated-on-circles
branch
from
December 16, 2019 12:01
1065f58 to
3513833
Compare
Member
Author
|
rebased as tests are fine locally. |
rullzer
approved these changes
Dec 16, 2019
Member
Author
|
@rullzer looks mergeable as the only issue is from a timeout |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maxence Lange maxence@artificial-owl.com