Skip to content

Migrate to @nextcloud/vue 1.x.x - #18917

Merged
rullzer merged 1 commit into
masterfrom
enhancement/migrate-to-nextcloud-vue-1
Jan 22, 2020
Merged

Migrate to @nextcloud/vue 1.x.x#18917
rullzer merged 1 commit into
masterfrom
enhancement/migrate-to-nextcloud-vue-1

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Jan 15, 2020

Copy link
Copy Markdown
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Jan 15, 2020
@skjnldsv skjnldsv self-assigned this Jan 15, 2020
@skjnldsv
skjnldsv force-pushed the enhancement/migrate-to-nextcloud-vue-1 branch from 4316893 to 1bc89b4 Compare January 16, 2020 10:10
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 16, 2020
@skjnldsv
skjnldsv marked this pull request as ready for review January 16, 2020 10:12
@skjnldsv

skjnldsv commented Jan 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is ready to review :)
I migrated apps and users, please have a look!

@nextcloud/vuejs everyone who coded in server, please check your code, that would help cleaning this up!
@blizzz too for the ldap specific stuff of the users management

@skjnldsv
skjnldsv requested a review from blizzz January 16, 2020 10:13
@skjnldsv

skjnldsv commented Jan 16, 2020

Copy link
Copy Markdown
Member Author

/compile /

@skjnldsv
skjnldsv requested a review from georgehrke January 16, 2020 10:15
ChristophWurst
ChristophWurst approved these changes Jan 16, 2020
View reviewed changes

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR of the day

@skjnldsv @juliusknorr
Migrate to @nextcloud/vue 1.x.x
05742c0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@juliusknorr
juliusknorr force-pushed the enhancement/migrate-to-nextcloud-vue-1 branch from 1bc89b4 to 05742c0 Compare January 22, 2020 16:34
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 22, 2020
@rullzer
rullzer merged commit 179a8b6 into master Jan 22, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the enhancement/migrate-to-nextcloud-vue-1 branch January 22, 2020 18:49
@juliusknorr juliusknorr mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes
@juliusknorr juliusknorr juliusknorr approved these changes
@rullzer rullzer Awaiting requested review from rullzer
@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini
@blizzz blizzz Awaiting requested review from blizzz
@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: dependencies high

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @ChristophWurst @juliusknorr @rullzer