Add a command to show info about a background job and force-execute it - #27217
Merged
Conversation
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
I like the command, but the implementation feels a bit fragile 🙈
can we leave any job list related responsibility in the job list code and only fetch/invoke the job from the new command?
nickvergessen
force-pushed
the
techdebt/noid/make-debugging-a-cron-job-easier
branch
from
May 31, 2021 15:16
956d663 to
27ee8a7
Compare
Member
|
This is great, I was always looking for such a feature. Would it be possible to add some kind of |
nickvergessen
force-pushed
the
techdebt/noid/make-debugging-a-cron-job-easier
branch
from
June 8, 2021 08:14
2ee7531 to
340cfac
Compare
blizzz
approved these changes
Jun 14, 2021
MorrisJobke
removed their request for review
July 4, 2021 11:34
Merged
nickvergessen
requested review from
a team,
MichaIng and
icewind1991
and removed request for
a team
October 13, 2021 09:43
skjnldsv
approved these changes
Oct 13, 2021
nickvergessen
force-pushed
the
techdebt/noid/make-debugging-a-cron-job-easier
branch
from
October 13, 2021 09:48
340cfac to
a68c891
Compare
Member
Author
|
Rebased cleanly and adjusted since versions to 23 |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/make-debugging-a-cron-job-easier
branch
from
October 14, 2021 07:59
a68c891 to
3adc997
Compare
Member
Author
|
Rebased and bumped autoloader |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second job info is only printed for "timed" jobs that are not deleted while being executed.