Add method to read multi-value attributes from ldap - #27515
Merged
Conversation
kesselb
force-pushed
the
enh/noid/read-multi-value-user-attribute
branch
2 times, most recently
from
June 15, 2021 19:31
610a240 to
e858b2b
Compare
kesselb
added
3. to review
blizzz
reviewed
Jun 16, 2021
blizzz
left a comment
blizzz
left a comment
Member
There was a problem hiding this comment.
looks good, just some phpdoc things to address
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
enh/noid/read-multi-value-user-attribute
branch
from
June 16, 2021 09:35
e858b2b to
04411df
Compare
10 tasks
blizzz
approved these changes
Jun 16, 2021
ChristophWurst
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getUserAttributeto usegetMultiValueUserAttributeinternally¹ we need this feature in Mail and will call
getMultiValueUserAttributefrequently. Yet I'm unsure about the caching because false fromreadAttributeis either no attribute found or something went wrong. I guess the current behavior to cache both is fine for our use case in Mail. A way to distinguish between "ldap is fine but not data" and "something went wrong" would be nice.