Full name section Vuetified - #28028
Merged
Merged
Conversation
11 tasks
Pytal
force-pushed
the
feat/27869/full-name
branch
2 times, most recently
from
July 22, 2021 00:14
e40dd2e to
954099c
Compare
Pytal
marked this pull request as ready for review
July 22, 2021 00:17
Pytal
requested review from
ChristophWurst,
artonge,
julien-nc,
juliusknorr,
nickvergessen and
skjnldsv
July 22, 2021 00:18
Pytal
added
3. to review
skjnldsv
reviewed
Jul 22, 2021
Pytal
force-pushed
the
feat/27869/full-name
branch
from
July 23, 2021 22:27
954099c to
411f790
Compare
Pytal
added
3. to review
Pytal
force-pushed
the
feat/27869/full-name
branch
from
July 23, 2021 22:35
411f790 to
6d8d279
Compare
artonge
previously requested changes
Jul 27, 2021
Pytal
force-pushed
the
feat/27869/full-name
branch
2 times, most recently
from
July 29, 2021 01:44
3c8fbc5 to
2740239
Compare
Pytal
force-pushed
the
feat/27869/full-name
branch
2 times, most recently
from
August 4, 2021 00:52
afde20a to
171c805
Compare
Pytal
force-pushed
the
feat/27869/full-name
branch
from
August 7, 2021 02:10
171c805 to
a86a874
Compare
Pytal
force-pushed
the
feat/27869/full-name
branch
from
August 16, 2021 20:26
dd06b5f to
ad38556
Compare
nextcloud-command
force-pushed
the
feat/27869/full-name
branch
2 times, most recently
from
August 17, 2021 23:22
210b9c0 to
f14fd02
Compare
Pytal
force-pushed
the
feat/27869/full-name
branch
2 times, most recently
from
August 17, 2021 23:30
ad38556 to
2949d8e
Compare
skjnldsv
reviewed
Aug 19, 2021
skjnldsv
reviewed
Aug 19, 2021
skjnldsv
approved these changes
Aug 19, 2021
Member
|
Good for me, other tiny comments can be addressed in follow-up :) |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/27869/full-name
branch
from
August 23, 2021 23:01
ce0c7da to
e9ccfbe
Compare
- Remove usage of JS core checkValidity() in favour of custom backend compliant validation - Rewrite and refactor with removal of form tag in favour of section - Scope styles - Remove many uses of $nextTick - Refine disabled state logic - Translate account property constants Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/27869/full-name
branch
from
August 24, 2021 23:00
a7a44fb to
d738ca4
Compare
Member
Author
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
juliusknorr
approved these changes
Aug 26, 2021
Member
|
Let's get this in. Nice work @Pytal :) |
Pytal
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Do
apps/settings/templates/settings/personal/persona.info.phpNote: The
TODOcomments are out-of-scope for this PR and will be addressed separately in future PRsContributes to #27869