[stable21] Fix comments file action sidebar opening - #28198
Merged
Conversation
backportbot-nextcloud
Bot
requested review from
CarlSchwan,
PVince81,
Pytal,
artonge,
julien-nc,
juliusknorr,
marcoambrosini,
skjnldsv and
szaimen
July 27, 2021 15:11
Member
|
/compile amend / |
nextcloud-bot
force-pushed
the
backport/27893/stable21
branch
from
July 27, 2021 15:45
acdd7e7 to
21ca868
Compare
julien-nc
force-pushed
the
backport/27893/stable21
branch
from
July 27, 2021 16:05
21ca868 to
482c680
Compare
Member
|
/compile amend / |
nextcloud-bot
force-pushed
the
backport/27893/stable21
branch
from
July 27, 2021 16:18
482c680 to
56c5c41
Compare
julien-nc
force-pushed
the
backport/27893/stable21
branch
from
July 27, 2021 21:34
56c5c41 to
fc8ab56
Compare
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
backport/27893/stable21
branch
from
July 28, 2021 08:15
fc8ab56 to
6bb95ee
Compare
Member
|
The checks for stable22 went well but this one is resisting 😕 The static code analysis issues are unrelated. If compilation is done by the compile bot, the node build check complains about "Uncommited changes in webpack build" which concerns the comments-app.js and comments-app.js.map which are not impacted by the changes of this PR. I think this can be merged. |
julien-nc
approved these changes
Jul 28, 2021
artonge
approved these changes
Jul 28, 2021
Member
|
Thanks @artonge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #27893