Emit event on link share action - #28764
Merged
Merged
Conversation
skjnldsv
force-pushed
the
feat/sharing-link-event
branch
from
September 8, 2021 18:10
9c2a38c to
4e2e82e
Compare
kesselb
approved these changes
Sep 8, 2021
skjnldsv
force-pushed
the
feat/sharing-link-event
branch
4 times, most recently
from
September 9, 2021 08:20
353e445 to
11b31ab
Compare
skjnldsv
added
3. to review
skjnldsv
requested review from
a team,
ArtificialOwl,
CarlSchwan,
artonge,
blizzz and
icewind1991
and removed request for
a team
September 9, 2021 15:37
skjnldsv
force-pushed
the
feat/sharing-link-event
branch
2 times, most recently
from
September 9, 2021 16:13
ba8521f to
e6da0e8
Compare
blizzz
reviewed
Sep 9, 2021
blizzz
approved these changes
Sep 9, 2021
blizzz
left a comment
blizzz
left a comment
Member
There was a problem hiding this comment.
one return type hint, otherwise 👍
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feat/sharing-link-event
branch
from
September 10, 2021 06:37
e6da0e8 to
c56c317
Compare
Member
|
@skjnldsv backport to 22? |
Member
Author
|
/backport to stable22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/skjnldsv/files_downloadcounter/
Follow-up: