Feat/webpack vendors bundles by skjnldsv · Pull Request #30020 · nextcloud/server

skjnldsv · 2021-12-01T19:04:15Z

Reduce compile time by a power of 4
Move all bundles into /dist
Easier to cleanup
Easier to target old legacy js files
No more vue- or js/dist hacks
Bundle all shared modules into one big cached file

Signed-off-by: Louis Chemineau <louis@chmn.me>

Reason: webpack/webpack#14628 Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: Louis Chemineau <louis@chmn.me>

Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: Louis Chemineau <louis@chmn.me>

skjnldsv · 2022-01-08T09:16:00Z

Rebased

skjnldsv · 2022-01-08T09:36:09Z

Scenario: delete a user                                                      # /drone/src/tests/acceptance/features/users.feature:25
130 | Given I act as Jane                                                        # ActorContext::iActAs()
131 | And I am logged in as the admin                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
132 | And I open the User settings                                               # SettingsMenuContext::iOpenTheUserSettings()
133 | And I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
134 | And I open the actions menu for the user user0                             # UsersSettingsContext::iOpenTheActionsMenuOf()
135 | And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
136 | Failed asserting that false is true.
137 | When I click the "Delete user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
138 | And I click the "Delete user0's account" button of the confirmation dialog # DialogContext::iClickTheDialogButton()
139 | Then I see that the list of users does not contains the user user0         # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
140

Is valid, the menu does not open anymore.

EDIT: fixed and pushed 🚀

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

skjnldsv · 2022-01-08T10:02:49Z

 * @param string $app the appname
 * @param string|string[] $file the filename,
 * if an array is given it will add all scripts
+ * @deprecated 23.1.0


Why 23.1.0 ?
Should be 24 ?

True, my bad

Please fix on followup so we don't yet rebase this monstrous PR 🙈

Also, please add a pointer to its replacement.

skjnldsv force-pushed the feat/webpack-vendors-bundles branch from c1b7257 to 2917225 Compare December 1, 2021 19:08

artonge force-pushed the feat/webpack-vendors-bundles branch from c4251a2 to e9039ed Compare December 1, 2021 21:34

skjnldsv force-pushed the feat/webpack-vendors-bundles branch 2 times, most recently from 80c15ed to 5adab26 Compare December 2, 2021 18:14

skjnldsv marked this pull request as ready for review December 2, 2021 18:14

skjnldsv requested review from a team, PVince81, Pytal, artonge, nickvergessen and szaimen and removed request for a team December 2, 2021 18:15

skjnldsv self-assigned this Dec 2, 2021

skjnldsv added 3. to review Waiting for reviews enhancement technical debt 🧱 🤔🚀 labels Dec 2, 2021

skjnldsv added this to the Nextcloud 24 milestone Dec 2, 2021

skjnldsv force-pushed the feat/webpack-vendors-bundles branch from 5adab26 to 8baf298 Compare December 2, 2021 18:21

artonge reviewed Dec 2, 2021

View reviewed changes

Comment thread core/src/OCP/collaboration.js

Comment thread lib/private/legacy/OC_Template.php Outdated

Comment thread webpack.common.js Outdated

Pytal reviewed Dec 2, 2021

View reviewed changes

Comment thread .eslintrc.js

skjnldsv force-pushed the feat/webpack-vendors-bundles branch 4 times, most recently from f5c36fe to 6eb2287 Compare December 2, 2021 21:41

Pytal mentioned this pull request Dec 3, 2021

Update custom vue event name casing rule nextcloud-libraries/eslint-config#249

Merged

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 3, 2021

artonge force-pushed the feat/webpack-vendors-bundles branch from 525c4ff to 60dc882 Compare December 3, 2021 13:04

skjnldsv force-pushed the feat/webpack-vendors-bundles branch from a290149 to b0db309 Compare December 3, 2021 13:19

This comment has been minimized.

Sign in to view

artonge added 10 commits January 8, 2022 10:15

Compile bundle

a6874aa

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix webpack version

cd53bc8

Reason: webpack/webpack#14628 Signed-off-by: Louis Chemineau <louis@chmn.me>

Don't import $ in every file that needs it

19ed04d

Signed-off-by: Louis Chemineau <louis@chmn.me>

Fix undescore version

9ee339d

Reason: #27279 Signed-off-by: Louis Chemineau <louis@chmn.me>

Restore line in autotest-js

db752fb

Signed-off-by: Louis Chemineau <louis@chmn.me>

Revert build/package-lock.json change

8a56713

Signed-off-by: Louis Chemineau <louis@chmn.me>

Detect app's script higher up as some scripts were shadowed

6f62c17

Signed-off-by: Louis Chemineau <louis@chmn.me>

Reset $scriptDeps in tests

447cd55

Signed-off-by: Louis Chemineau <louis@chmn.me>

Deprecate script function

d3661c7

Signed-off-by: Louis Chemineau <louis@chmn.me>

Bump p-queue

9ed12e8

Signed-off-by: Louis Chemineau <louis@chmn.me>

skjnldsv force-pushed the feat/webpack-vendors-bundles branch from 1c37a42 to 9ed12e8 Compare January 8, 2022 09:16

skjnldsv requested review from MichaIng and mejo- January 8, 2022 09:17

This comment has been minimized.

Sign in to view

Use sync modifier with openMenu

79f14e8

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

nextcloud-command force-pushed the feat/webpack-vendors-bundles branch from 1e2f3db to 79f14e8 Compare January 8, 2022 09:59

skjnldsv commented Jan 8, 2022

View reviewed changes

Comment thread lib/public/Util.php

artonge approved these changes Jan 9, 2022

View reviewed changes

CarlSchwan approved these changes Jan 10, 2022

View reviewed changes

CarlSchwan merged commit 91c7efa into master Jan 10, 2022

CarlSchwan deleted the feat/webpack-vendors-bundles branch January 10, 2022 08:41

artonge mentioned this pull request Jan 27, 2022

Add deprecation notice to script & addScript func #30876

Merged

This was referenced Feb 11, 2022

Replace CalDAV availability component with component lib #29796

Merged

Add back missing personal Groupware settings bundle #31131

Closed

Fix missign twofactor_backupcodes bundle #31132

Merged

artonge mentioned this pull request Feb 18, 2022

Load scripts of theming app before the dashboard #31238

Merged

juliusknorr mentioned this pull request Mar 8, 2022

Avoid double-loading dist/core-main.js when apps have scripts named main #31493

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Feat/webpack vendors bundles - #30020

Feat/webpack vendors bundles#30020
CarlSchwan merged 28 commits into
masterfrom
feat/webpack-vendors-bundles

skjnldsv commented Dec 1, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

skjnldsv commented Jan 8, 2022

Uh oh!

skjnldsv commented Jan 8, 2022 •

edited

Loading

Uh oh!

This comment has been minimized.

skjnldsv Jan 8, 2022

Uh oh!

artonge Jan 8, 2022

Uh oh!

skjnldsv Jan 8, 2022

Uh oh!

blizzz Jan 26, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

skjnldsv commented Dec 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

skjnldsv commented Jan 8, 2022

Uh oh!

skjnldsv commented Jan 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

skjnldsv Jan 8, 2022

Choose a reason for hiding this comment

Uh oh!

artonge Jan 8, 2022

Choose a reason for hiding this comment

Uh oh!

skjnldsv Jan 8, 2022

Choose a reason for hiding this comment

Uh oh!

blizzz Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

skjnldsv commented Dec 1, 2021 •

edited

Loading

skjnldsv commented Jan 8, 2022 •

edited

Loading