Add comments reactions - #30379
Merged
Merged
Conversation
vitormattos
added
enhancement
2. developing
vitormattos
marked this pull request as draft
December 22, 2021 18:12
Author
|
static tests fixed on #30370 |
vitormattos
force-pushed
the
feature/add-comments-reactions
branch
2 times, most recently
from
December 23, 2021 13:07
f1e67ef to
3c23050
Compare
This was referenced Dec 23, 2021
vitormattos
force-pushed
the
feature/add-comments-reactions
branch
3 times, most recently
from
December 24, 2021 14:09
09b4c79 to
a786259
Compare
vitormattos
requested review from
ChristophWurst,
danxuliu and
nickvergessen
December 27, 2021 13:05
vitormattos
marked this pull request as ready for review
December 27, 2021 13:13
vitormattos
added
3. to review
vitormattos
force-pushed
the
feature/add-comments-reactions
branch
5 times, most recently
from
December 30, 2021 23:35
1c08c52 to
006a4a3
Compare
nickvergessen
requested changes
Jan 2, 2022
vitormattos
force-pushed
the
feature/add-comments-reactions
branch
2 times, most recently
from
January 2, 2022 19:36
aed1b13 to
394b84b
Compare
CarlSchwan
approved these changes
Jan 20, 2022
nickvergessen
added
4. to release
danxuliu
requested changes
Jan 20, 2022
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
The asserts from testReactionAddAndDelete are not executed, and there might be a missing call to throwIfNotSupportReactions() in retrieveAllReactionsWithSpecificReaction().
The other comments are just things that would be nice to have, but not really needed.
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Fix column size Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
feature/add-comments-reactions
branch
from
January 21, 2022 11:45
e871521 to
7bb01b6
Compare
Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes on app comments to resolve nextcloud/spreed#1920
Depends of #30393 and #30378