Remove inefficient fed share scanner - #30499
Merged
PVince81 merged 1 commit intoJan 10, 2022
Merged
Conversation
PVince81
force-pushed
the
bugfix/29941/remove-shareinfo-query-from-scanner
branch
from
January 7, 2022 08:17
1115141 to
a8dea0f
Compare
Member
Author
|
cool, no failure related to federated sharing
|
Member
Author
|
I've done a manual test as follows:
After the sync, the new folder "e" got synced. So it all works fine with this PR 😀 Please review! |
PVince81
requested review from
CarlSchwan,
artonge,
icewind1991 and
nickvergessen
January 7, 2022 12:50
PVince81
force-pushed
the
bugfix/29941/remove-shareinfo-query-from-scanner
branch
from
January 7, 2022 12:52
a8dea0f to
6b081a7
Compare
PVince81
marked this pull request as ready for review
January 7, 2022 12:52
skjnldsv
approved these changes
Jan 10, 2022
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Needs a rebase, but all good 🚀
CarlSchwan
approved these changes
Jan 10, 2022
PVince81
force-pushed
the
bugfix/29941/remove-shareinfo-query-from-scanner
branch
from
January 10, 2022 09:00
6b081a7 to
8844b97
Compare
Remove scanAll which relies on the "shareinfo" endpoint that returns the full cache tree. The latter can become big for big shares and result in timeouts. Furthermode, the full tree would be retrieved again for each and every detected change which can become expensive quickly. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/29941/remove-shareinfo-query-from-scanner
branch
from
January 10, 2022 10:33
8844b97 to
ce31914
Compare
icewind1991
approved these changes
Jan 10, 2022
Member
Author
|
JS failure unrelated, merging |
Member
|
Does this qualify for backport? |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
This was referenced Jan 14, 2022
Member
Author
thanks for your usual reminders 😄 |
8 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove scanAll which relies on the "shareinfo" endpoint that returns the
full cache tree.
The latter can become big for big shares and result in timeouts.
Furthermode, the full tree would be retrieved again for each and every
detected change which can become expensive quickly.
As discussed with @icewind1991
Draft for now, needs more extensive testing to confirm that the default scanner will work correctly for federated shares.
Fixes #29941