Fix idn emails not working in shares

[CarlSchwan]

Fix #30595

Signed-off-by: Carl Schwan carl@carlschwan.eu

[tcitworld]

You can use OCP\Mail\Mailer::validateMailAddress that already has the IDN check.

server/lib/private/Mail/Mailer.php

Lines 216 to 249 in 796764a

	/**
	* Checks if an e-mail address is valid
	*
	* @param string $email Email address to be validated
	* @return bool True if the mail address is valid, false otherwise
	*/
	public function validateMailAddress(string $email): bool {
	if ($email === '') {
	// Shortcut: empty addresses are never valid
	return false;
	}
	$validator = new EmailValidator();
	$validation = new RFCValidation();
	return $validator->isValid($this->convertEmail($email), $validation);
	}
	/**
	* SwiftMailer does currently not work with IDN domains, this function therefore converts the domains
	*
	* FIXME: Remove this once SwiftMailer supports IDN
	*
	* @param string $email
	* @return string Converted mail address if `idn_to_ascii` exists
	*/
	protected function convertEmail(string $email): string {
	if (!function_exists('idn_to_ascii') || !defined('INTL_IDNA_VARIANT_UTS46') || strpos($email, '@') === false) {
	return $email;
	}
	[$name, $domain] = explode('@', $email, 2);
	$domain = idn_to_ascii($domain, 0,INTL_IDNA_VARIANT_UTS46);
	return $name.'@'.$domain;
	}

[PVince81]

👍

[PVince81]

if possible for this code path would be good to add unit tests with an IDN address

[CarlSchwan]

I'm looking into the php unit failures, strange that is works locally for me :/

[CarlSchwan]

I found why the tests seemed to work locally and fixed them :)

[PVince81]

👍

[CarlSchwan]

/backport to stable23

[CarlSchwan]

/backport to stable22

[CarlSchwan]

/backport to stable21