cache storage id mapping both ways - #31776
Merged
Merged
Conversation
icewind1991
requested review from
a team,
blizzz,
nickvergessen and
vanpertsch
and removed request for
a team
March 31, 2022 12:11
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
storage-id-cache-bi-directional
branch
from
March 31, 2022 12:35
060b0f7 to
ac657b0
Compare
blizzz
approved these changes
Apr 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to query the numeric id by storage id if we've just queried it the other way around.