Cleanup avatar related code - #32973
Merged
Merged
Conversation
CarlSchwan
commented
Jun 22, 2022
CarlSchwan
commented
Member
- Move event listener to new event handling
- Add typing almost everywhere
- Fix inconsistent interface parameter
CarlSchwan
requested review from
PVince81,
blizzz and
skjnldsv
and removed request for
a team
June 22, 2022 10:13
CarlSchwan
force-pushed
the
cleanup/avatar-code
branch
from
June 22, 2022 13:30
336852d to
aafd432
Compare
- Move event listener to new event handling - Add typing almost everywhere - Fix inconsistent interface parameter Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
cleanup/avatar-code
branch
from
June 22, 2022 14:11
aafd432 to
812016d
Compare
CarlSchwan
force-pushed
the
cleanup/avatar-code
branch
2 times, most recently
from
June 23, 2022 12:28
f6515a9 to
d7db080
Compare
come-nc
reviewed
Jun 23, 2022
blizzz
reviewed
Jun 23, 2022
CarlSchwan
force-pushed
the
cleanup/avatar-code
branch
2 times, most recently
from
June 24, 2022 08:23
d541c9d to
a440a88
Compare
Member
|
hrumph
|
skjnldsv
removed their request for review
July 5, 2022 10:48
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
cleanup/avatar-code
branch
from
July 5, 2022 12:44
a440a88 to
ec5cbde
Compare
blizzz
reviewed
Jul 8, 2022
come-nc
approved these changes
Jul 11, 2022
joshtrichards
added a commit
that referenced
this pull request
Apr 19, 2026
See #32973 Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
pushed a commit
that referenced
this pull request
May 11, 2026
See #32973 Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
pushed a commit
that referenced
this pull request
May 11, 2026
See #32973 Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.