DashBoard : Allow up to 5 widgets side by side - #34191
Merged
Merged
Conversation
Signed-off-by: Jérôme Herbinet <j.herbinet@protonmail.ch> Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
nickvergessen
approved these changes
Sep 22, 2022
nimishavijay
approved these changes
Sep 22, 2022
jancborchardt
approved these changes
Sep 22, 2022
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Good stuff, thank you! :)
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Member
|
/backport to stable25 |
Member
|
Compiled js added in #34231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like many people, I have a resolution of 1920x1080 (and more and more people have even higher resolutions) ... and I think more widgets should be allowed side by side. This is in my opinion a good compromise.
Note : This change does not change anything for people with lower resolutions.
Before, on my 1920x1080 screen :
After, on my 1920x1080 screen :
Signed-off-by: Jérôme Herbinet j.herbinet@protonmail.ch
Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com