Skip to content

Fix various theming bugs - #34204

Merged
Pytal merged 1 commit into
masterfrom
fix/flashing-background-color
Sep 28, 2022
Merged

Fix various theming bugs#34204
Pytal merged 1 commit into
masterfrom
fix/flashing-background-color

Conversation

@Pytal

@Pytal Pytal commented Sep 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member
  • Fix flashing background color with new --color-main-background-plain CSS variable and --color-main-background fallback
  • Fix missing checkmark when plain background is selected
  • Fix plain background not being used on pages other than Appearance and accessibility and dashboard pages
  • Fix plain background not being set without a reload by automatically refreshing server-side generated CSS
  • Remove js style overrides in favour of automatically refreshing server-side generated CSS on background change

@Pytal Pytal added the 2. developing Work in progress label Sep 23, 2022
@Pytal Pytal self-assigned this Sep 23, 2022
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal mentioned this pull request Sep 23, 2022
Closed
1 task
@szaimen

szaimen commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Does this also resolve #33840?

@skjnldsv

This comment was marked as resolved.

Sign in to view
@Pytal
Pytal force-pushed the fix/flashing-background-color branch from 2b6b2e2 to 49ebc21 Compare September 24, 2022 00:03
@Pytal Pytal changed the title Fix flashing background color Fix various theming bugs Sep 24, 2022
@Pytal

Pytal commented Sep 24, 2022

Copy link
Copy Markdown
Member Author

Does this also resolve #33840?

Cannot reproduce but changed code does not seem related so probably needs to be fixed separately 🤔

@Pytal Pytal added bug 3. to review Waiting for reviews feature: theming feature: dashboard and removed 2. developing Work in progress labels Sep 24, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Sep 24, 2022
@Pytal
Pytal marked this pull request as ready for review September 24, 2022 00:08
szaimen
szaimen approved these changes Sep 26, 2022
View reviewed changes

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@szaimen

szaimen commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

@Pytal needs a rebase...

@Pytal
Pytal force-pushed the fix/flashing-background-color branch from 49ebc21 to 0c92bee Compare September 26, 2022 18:27
@szaimen
szaimen requested review from a team, GretaD, PVince81 and artonge and removed request for a team September 26, 2022 19:29
@blizzz blizzz mentioned this pull request Sep 27, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 27, 2022
@blizzz

blizzz commented Sep 27, 2022

Copy link
Copy Markdown
Member

master is 26, please trigger a backport if necessary.

@Pytal

Pytal commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

/backport to stable25

@Pytal Pytal mentioned this pull request Sep 28, 2022
Merged
@Pytal

Pytal commented Sep 28, 2022

Copy link
Copy Markdown
Member Author

Please review as this is needed to fix theming bugs and to auto-refresh styles in #34298 :)

@szaimen

szaimen commented Sep 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I already approved... Kaybe @skjnldsv can do the other review?

PVince81
PVince81 approved these changes Sep 28, 2022
View reviewed changes

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81

PVince81 commented Sep 28, 2022

Copy link
Copy Markdown
Member

please check CI, the app theming seems to have found a bug

@Pytal
Fix various theming bugs
295d038 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytal force-pushed the fix/flashing-background-color branch from 0c92bee to 295d038 Compare September 28, 2022 17:13
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2022
@Pytal
Pytal merged commit 054d266 into master Sep 28, 2022
@Pytal
Pytal deleted the fix/flashing-background-color branch September 28, 2022 17:57
@backportbot-nextcloud backportbot-nextcloud Bot mentioned this pull request Sep 28, 2022
Merged
@Pytal Pytal mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes
@szaimen szaimen szaimen approved these changes
@juliusknorr juliusknorr Awaiting requested review from juliusknorr
@skjnldsv skjnldsv Awaiting requested review from skjnldsv
@GretaD GretaD Awaiting requested review from GretaD
@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dashboard feature: theming

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal @szaimen @skjnldsv @blizzz @PVince81