Only check unsupported browsers on user rendering - #34741
Merged
Conversation
skjnldsv
requested review from
ArtificialOwl,
icewind1991 and
juliusknorr
and removed request for
a team
October 22, 2022 10:50
skjnldsv
force-pushed
the
fix/unsupported-browsers-user-only
branch
from
October 22, 2022 10:56
9f1e50c to
f671d28
Compare
skjnldsv
force-pushed
the
fix/unsupported-browsers-user-only
branch
from
October 22, 2022 11:03
f671d28 to
448e3d0
Compare
AlvaroBrey
approved these changes
Oct 24, 2022
AlvaroBrey
left a comment
Member
There was a problem hiding this comment.
Can confirm the mobile app can log in properly with this branch
szaimen
approved these changes
Oct 27, 2022
szaimen
left a comment
Contributor
There was a problem hiding this comment.
I fear I can only give a 🐘.
Not sure if that is enough...
Contributor
|
Also conflicts |
skjnldsv
force-pushed
the
fix/unsupported-browsers-user-only
branch
from
October 28, 2022 08:14
448e3d0 to
8d3b4be
Compare
tobiasKaminsky
approved these changes
Oct 28, 2022
skjnldsv
force-pushed
the
fix/unsupported-browsers-user-only
branch
2 times, most recently
from
October 28, 2022 10:15
088e650 to
6610ce1
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/unsupported-browsers-user-only
branch
from
October 28, 2022 10:23
6610ce1 to
a8e8a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #26358 (comment)