[stable24] Fix HTML entities not decoded in comment just added - #35100
Merged
Conversation
Member
|
/compile amend / |
nextcloud-command
force-pushed
the
backport/35054/stable24
branch
from
November 11, 2022 10:26
5620de3 to
4014a9e
Compare
blizzz
requested review from
a team,
PVince81,
artonge and
skjnldsv
and removed request for
a team
November 23, 2022 17:26
Contributor
|
Conflicts... |
Member
|
/compile amend / |
blizzz
enabled auto-merge
November 23, 2022 20:18
nextcloud-command
force-pushed
the
backport/35054/stable24
branch
from
November 23, 2022 20:42
4014a9e to
d8aa55f
Compare
Member
|
still conflicts? 🤷 |
danxuliu
force-pushed
the
backport/35054/stable24
branch
from
November 24, 2022 09:54
d8aa55f to
dd2a6d7
Compare
Member
|
/compile / |
This will make possible to use it from files other than "GetComments.js". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The XML data received from the comments endpoint has an inconsistent encoding; some entities are encoded once and others are encoded twice. When the comment list is loaded the comments are fetched using GetComments, which handles all that, and therefore shows the messages and author names as expected. However, when a new comment is posted the list is not got again; instead the new comment is loaded from the comment data returned after posting it. This is done in NewComment, which did not decode the messages nor the author names, and therefore showed, for example, "&" instead of "&". To solve that now the same decoding logic used in GetComments is applied too in NewComment. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/35054/stable24
branch
from
November 24, 2022 16:20
0939c25 to
d3807ea
Compare
Member
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport had conflicts and is incompletebackport of #35054