Skip to content

[stable22] Cap node version to 12 - #35463

Merged
artonge merged 2 commits into
stable22from
fix/compilation
Dec 1, 2022
Merged

[stable22] Cap node version to 12#35463
artonge merged 2 commits into
stable22from
fix/compilation

Conversation

@artonge

@artonge artonge commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator

Node 17 and superior break compilation

Needed for #35440

@artonge
artonge enabled auto-merge November 28, 2022 14:34
@artonge artonge self-assigned this Nov 28, 2022
@artonge artonge closed this Nov 28, 2022
auto-merge was automatically disabled November 28, 2022 14:36

Pull request was closed

@artonge artonge reopened this Nov 30, 2022
@artonge
artonge requested review from a team, PVince81, Pytal, danxuliu and skjnldsv and removed request for a team November 30, 2022 14:02
@artonge artonge added dependencies 3. to review Waiting for reviews labels Nov 30, 2022
@artonge artonge added this to the Nextcloud 22.2.11 milestone Nov 30, 2022
Comment thread package.json Outdated

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szaimen szaimen changed the title Cap node version to 16 [stable22] Cap node version to 16 Nov 30, 2022
Node 17 and superior break compilation

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge changed the title [stable22] Cap node version to 16 [stable22] Cap node version to 12 Dec 1, 2022
@artonge
artonge requested a review from skjnldsv December 1, 2022 11:55
Signed-off-by: Louis <6653109+artonge@users.noreply.github.com>
@artonge
artonge enabled auto-merge December 1, 2022 16:22
@artonge

artonge commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator Author

CI failure unrelated

@artonge
artonge disabled auto-merge December 1, 2022 17:29
@artonge
artonge merged commit 32912b6 into stable22 Dec 1, 2022
@artonge
artonge deleted the fix/compilation branch December 1, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants