Add accessible system tags select - #37065
Merged
Merged
Conversation
3 tasks
Merged
Member
|
master is 27 |
Pytal
force-pushed
the
enh/a11y-system-tags
branch
2 times, most recently
from
March 16, 2023 17:06
36fd841 to
d696ea8
Compare
Pytal
force-pushed
the
enh/a11y-system-tags
branch
from
March 31, 2023 01:50
d696ea8 to
d8ea161
Compare
Pytal
force-pushed
the
enh/a11y-system-tags
branch
from
April 12, 2023 03:53
d8ea161 to
a94adf0
Compare
Pytal
requested review from
JuliaKirschenheuter,
artonge,
juliusknorr,
kesselb and
skjnldsv
and removed request for
JuliaKirschenheuter and
kesselb
April 12, 2023 04:10
This comment was marked as outdated.
This comment was marked as outdated.
Pytal
marked this pull request as ready for review
April 12, 2023 04:13
nextcloud-command
force-pushed
the
enh/a11y-system-tags
branch
from
April 12, 2023 04:22
a94adf0 to
7d15005
Compare
Pytal
force-pushed
the
enh/a11y-system-tags
branch
6 times, most recently
from
April 14, 2023 21:51
6018d67 to
b3fdc6b
Compare
artonge
approved these changes
Apr 17, 2023
Pytal
force-pushed
the
enh/a11y-system-tags
branch
from
April 18, 2023 01:34
b3fdc6b to
9f6056a
Compare
JuliaKirschenheuter
approved these changes
Apr 18, 2023
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
enh/a11y-system-tags
branch
from
April 19, 2023 23:52
9f6056a to
177849c
Compare
2 tasks
2 tasks
pulsejet
added a commit
that referenced
this pull request
Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
nextcloud-command
pushed a commit
that referenced
this pull request
Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
pulsejet
added a commit
that referenced
this pull request
Oct 17, 2023
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
pulsejet
added a commit
that referenced
this pull request
Nov 27, 2023
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
nextcloud-command
pushed a commit
that referenced
this pull request
Nov 27, 2023
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
zak39
pushed a commit
to zak39/server
that referenced
this pull request
Dec 19, 2023
With nextcloud#37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
backportbot Bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> [skip ci]
nextcloud-command
pushed a commit
that referenced
this pull request
Jul 4, 2024
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
solracsf
pushed a commit
that referenced
this pull request
Jul 5, 2024
With #37065, there is no way to hide the tags from the sidebar by default when they are not relevant or redundant (e.g. the tab may already show the file's tags). This can be annyoing especially when the file has many tags. This patch adds an option to hide the tags from the sidebar by default (the user can still open the tags tab manually). This also reduces one request when opening the sidebar when the tags are turned off, since all tags don't need to be fetched anymore. Signed-off-by: Varun Patil <varunpatil@ucla.edu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
FIXMEs are out-of-scope
The
parseIdFromLocation()util was adapted fromserver/core/src/OC/backbone-webdav.js
Lines 86 to 102 in 7300017
TODO
webdavlib for DAV requestsChecklist