Replace id3parser with mp3info - #38498
Merged
Merged
Conversation
kesselb
force-pushed
the
feat-replace-id3parser-with-mp3info
branch
3 times, most recently
from
June 1, 2023 18:25
8c32e9c to
4ed04e6
Compare
kesselb
force-pushed
the
feat-replace-id3parser-with-mp3info
branch
from
June 26, 2023 12:16
4ed04e6 to
63ea2f9
Compare
kesselb
added
3. to review
szaimen
requested review from
a team,
ArtificialOwl and
nfebe
and removed request for
a team
June 26, 2023 12:21
come-nc
approved these changes
Jun 26, 2023
kesselb
force-pushed
the
feat-replace-id3parser-with-mp3info
branch
from
June 27, 2023 09:03
63ea2f9 to
e0eb1c3
Compare
ChristophWurst
approved these changes
Jun 28, 2023
ChristophWurst
marked this pull request as draft
June 28, 2023 12:14
Member
|
Setting as draft to prevent accidental merges |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feat-replace-id3parser-with-mp3info
branch
from
June 28, 2023 12:59
e0eb1c3 to
3757f39
Compare
kesselb
marked this pull request as ready for review
June 28, 2023 12:59
Contributor
Author
Thanks! Updated the 3rdparty submodule and rebased. |
ChristophWurst
approved these changes
Jun 28, 2023
nfebe
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We forked getID3 to provide a library to only read MP3 files but nothing else.
Our primary use case is to use an embedded image as a preview.
Mp3Info seems like a nice and lightweight replacement for getID3.
TODO
Checklist