Skip to content

chore(ocp)!: Drop \OCP\Util::writeLog - #38548

Closed
ChristophWurst wants to merge 3 commits into
masterfrom
chore/ocp/drop-until-writelog
Closed

chore(ocp)!: Drop \OCP\Util::writeLog#38548
ChristophWurst wants to merge 3 commits into
masterfrom
chore/ocp/drop-until-writelog

Conversation

@ChristophWurst

@ChristophWurst ChristophWurst commented May 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

The method was deprecated in Nextcloud 13, released 2018-02-06.

TODO

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 31, 2023
@ChristophWurst ChristophWurst self-assigned this May 31, 2023
@ChristophWurst ChristophWurst mentioned this pull request May 31, 2023
Closed
CarlSchwan
CarlSchwan approved these changes May 31, 2023
View reviewed changes

@CarlSchwan CarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice one less way to write logs :)

solracsf
solracsf approved these changes May 31, 2023
View reviewed changes

@solracsf solracsf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve (this has been logged).

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish pending documentation This pull request needs an associated documentation update and removed 3. to review Waiting for reviews labels May 31, 2023
susnux
susnux approved these changes May 31, 2023
View reviewed changes

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ChristophWurst
ChristophWurst force-pushed the chore/ocp/drop-until-writelog branch from 721f9ee to 33f8c86 Compare May 31, 2023 17:18
@ChristophWurst

ChristophWurst commented May 31, 2023

Copy link
Copy Markdown
Member Author

Fixed unused imports. Should be fine now.

kesselb
kesselb reviewed May 31, 2023
View reviewed changes
Comment thread lib/private/Tags.php
$tag = trim($tag);
if ($tag === '') {
\OCP\Util::writeLog('core', __METHOD__.', Cannot add an empty tag', ILogger::DEBUG);
logger('core')->debug(__METHOD__.', Cannot add an empty tag');

@kesselb kesselb May 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$this->logger is also available ;)

@ChristophWurst ChristophWurst May 31, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@ChristophWurst
ChristophWurst force-pushed the chore/ocp/drop-until-writelog branch from 33f8c86 to b915825 Compare June 1, 2023 16:34
@szaimen
szaimen force-pushed the chore/ocp/drop-until-writelog branch from b915825 to d995f11 Compare June 12, 2023 07:43
@szaimen
szaimen enabled auto-merge June 12, 2023 07:44
@ChristophWurst
ChristophWurst force-pushed the chore/ocp/drop-until-writelog branch from d995f11 to 46cfd66 Compare July 24, 2023 12:02
@ChristophWurst
ChristophWurst force-pushed the chore/ocp/drop-until-writelog branch from 46cfd66 to 0dd616f Compare September 5, 2023 14:09
@ChristophWurst
chore: Replace \OCP\Util::writeLog with \OCP\Log\logger calls
504a8ea 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore(ocp)!: Drop \OCP\Util::writeLog
76f017a 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
chore(appframework): Remove deprecated and unused DIContainer::log
e2faf6d 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurst force-pushed the chore/ocp/drop-until-writelog branch from 64318fe to e2faf6d Compare September 18, 2023 19:21
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Feb 23, 2024
@skjnldsv
skjnldsv disabled auto-merge February 23, 2024 14:03
@skjnldsv

skjnldsv commented Feb 23, 2024

Copy link
Copy Markdown
Member

Superseded by #40565

@skjnldsv skjnldsv closed this Feb 23, 2024
@skjnldsv
skjnldsv deleted the chore/ocp/drop-until-writelog branch February 23, 2024 14:12
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb left review comments
@rullzer rullzer rullzer approved these changes
@susnux susnux susnux approved these changes
@solracsf solracsf solracsf approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@blizzz blizzz Awaiting requested review from blizzz
@JohannesGGE JohannesGGE Awaiting requested review from JohannesGGE

Assignees

@ChristophWurst ChristophWurst

Labels

2. developing Work in progress feature: logging technical debt 🧱 🤔🚀

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ChristophWurst @skjnldsv @rullzer @susnux @kesselb @solracsf @CarlSchwan