fix(sse): don't update uncached files - #39115
Merged
Merged
Conversation
st3iny
marked this pull request as draft
July 3, 2023 07:48
st3iny
added
bug
2. developing
![github-advanced-security[bot]](https://cdn.github.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/unecrypted-size-part-files
branch
from
July 4, 2023 10:42
f84dda4 to
c4eccbb
Compare
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
st3iny
marked this pull request as ready for review
July 4, 2023 10:43
st3iny
added
3. to review
st3iny
requested review from
a team,
ArtificialOwl and
blizzz
and removed request for
a team
July 4, 2023 13:54
blizzz
approved these changes
Jul 4, 2023
This was referenced Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Certain files (e.g. *.part) are not cached in the file cache and thus have no
fileid. However, the encryption storage wrapper tries to update their cache entries regardless which will fail as$info->getId()throws an exception ("Undefined array key \"fileid\").Checklist