Skip to content

fix(comments): Emit CommentsEntityEvent as typed event - #39304

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/typed-event-comments-entity
Jul 19, 2023
Merged

fix(comments): Emit CommentsEntityEvent as typed event#39304
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/typed-event-comments-entity

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Fix #1539

Checklist

@nickvergessen nickvergessen added enhancement 3. to review Waiting for reviews feature: dav feature: comments pending documentation This pull request needs an associated documentation update labels Jul 11, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jul 11, 2023
@nickvergessen
nickvergessen requested review from a team, ChristophWurst and marcelklehr July 11, 2023 09:10
@nickvergessen nickvergessen self-assigned this Jul 11, 2023
@nickvergessen
nickvergessen requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a team July 11, 2023 09:10
@nickvergessen
nickvergessen marked this pull request as draft July 11, 2023 09:57
@nickvergessen nickvergessen mentioned this pull request Jul 13, 2023
Closed
@nickvergessen
nickvergessen force-pushed the bugfix/noid/typed-event-comments-entity branch from de58d50 to 5cc8c03 Compare July 18, 2023 12:45
@nickvergessen
fix(comments): Emit CommentsEntityEvent as typed event
c3bc575 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessen force-pushed the bugfix/noid/typed-event-comments-entity branch from 5cc8c03 to c3bc575 Compare July 18, 2023 14:20
@nickvergessen
nickvergessen requested review from come-nc and kesselb July 18, 2023 14:21
@nickvergessen
nickvergessen marked this pull request as ready for review July 18, 2023 14:21
kesselb
kesselb approved these changes Jul 18, 2023
View reviewed changes

@kesselb kesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nickvergessen
nickvergessen merged commit 489b480 into master Jul 19, 2023
@nickvergessen
nickvergessen deleted the bugfix/noid/typed-event-comments-entity branch July 19, 2023 15:25
@nickvergessen nickvergessen mentioned this pull request Jul 28, 2023
Merged
15 tasks
@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Jul 28, 2023
@nickvergessen

nickvergessen commented Jul 28, 2023

Copy link
Copy Markdown
Member Author

Docs in nextcloud/documentation#10858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes
@kesselb kesselb kesselb approved these changes
@come-nc come-nc come-nc approved these changes
@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews enhancement feature: comments feature: dav

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Comments: Replace CommentEntityEvent with a registration-bases solution within CommentsManager.

4 participants

@nickvergessen @marcelklehr @kesselb @come-nc