fix: redirect to proper directory if file not found - #40515
Merged
Conversation
skjnldsv
requested review from
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
September 19, 2023 19:01
skjnldsv
commented
Sep 19, 2023
![github-advanced-security[bot]](https://cdn.github.com/in/57789?s=60&v=4){kind=small}
| if ($fileid && $dir !== '') { | ||
| $baseFolder = $this->rootFolder->getUserFolder($userId); | ||
| $nodes = $baseFolder->getById((int) $fileid); | ||
| $relativePath = dirname($baseFolder->getRelativePath($nodes[0]->getPath())); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
skjnldsv
force-pushed
the
fix/redirect-if-wrong-dir
branch
from
September 26, 2023 18:47
a2b76c8 to
3f0a9f2
Compare
Member
Author
|
Ping everyone! 🙏 |
skjnldsv
force-pushed
the
fix/redirect-if-wrong-dir
branch
from
October 4, 2023 06:50
3f0a9f2 to
1349e2a
Compare
Altahrim
approved these changes
Oct 4, 2023
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/redirect-if-wrong-dir
branch
from
October 4, 2023 09:29
1349e2a to
b05719c
Compare
max-nextcloud
approved these changes
Oct 4, 2023
miaulalala
approved these changes
Oct 4, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #32177
Fix #40104