fix(theming): Add aria-pressed attribute to active background - #40950
Merged
Conversation
susnux
added
bug
3. to review
susnux
requested review from
AndyScherzinger,
JuliaKirschenheuter,
Pytal and
skjnldsv
October 17, 2023 13:19
susnux
force-pushed
the
fix/add-aria-pressed-to-buttons
branch
from
October 17, 2023 13:25
eb57831 to
9c3ec4b
Compare
skjnldsv
approved these changes
Oct 17, 2023
Contributor
Author
|
Failing cypress is caused by regression of |
Pytal
approved these changes
Oct 17, 2023
AndyScherzinger
approved these changes
Oct 17, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/add-aria-pressed-to-buttons
branch
from
October 17, 2023 23:36
9c3ec4b to
8d57cdc
Compare
susnux
enabled auto-merge
October 17, 2023 23:36
susnux
disabled auto-merge
October 18, 2023 00:16
Contributor
Author
|
cypress unrelated (password confirmation issue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
aria-pressedstate to currently active background image (buttons).Checklist