Replace input filed with password field and added password error message

[JuliaKirschenheuter]

• Resolves: [BITV] 9.3.3.1/3.1 - Section "Details" / tab "Sharing": When the field with the password is left empty, no error message is displayed, which is necessary. The field only receives a red border, and an error icon appears. (2) #41882

Summary

• Replace input filed with password field and added password error message
• Remove unneeded NcDateTimePicker

Before:

After:

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[JuliaKirschenheuter]

/backport to stable28

[ShGKme]

Fixes the issue, but has 2 drawbacks:

• Now a user always needs +1 more click to see the generated password
• On edit of saved password, this might not be clear that an empty password field is a new password field and there is a password.

@nextcloud/designers What do you think?

[jancborchardt]

Now a user always needs +1 more click to see the generated password

This I’d say is less of an issue

On edit of saved password, this might not be clear that an empty password field is a new password field and there is a password.

@ShGKme I’m not sure I fully understand, especially the part "[…] is a new password field and there is a password" – it looks fine from your posted video above, but it only shows one flow.

[ShGKme]

This I’d say is less of an issue

Just to be clear, a user always needs it because checking "set password" generates a random password.

@ShGKme I’m not sure I fully understand, especially the part "[…] is a new password field and there is a password" – it looks fine from your posted video above, but it only shows one flow.

When you open an existing share with a password, you see:

I'm not sure that it is clear that it is "enter a new password to change it" and not "you have set a password and it is an empty password".

[jancborchardt]

@ShGKme thanks for explaining. Well both of those cases are confusing, the second one even more than the first. In both cases, ideally the password should be shown in plain text from a UX point of view.

If that is a security concern, instead of the plain input field we could instead show feedback text like:

• New: Password generated [ Copy ] [ Edit ]
• Existing: Password set [ Copy ] [ Edit ]

That way it would also be a 2-step process, but way clearer what it is about, and clicking on "Edit" should also directly show the password in plain text.

[ShGKme]

In both cases, ideally the password should be shown in plain text from a UX point of view.

We can show the password only when a user checks "Set password" and a new password is generated.

Here the only issue could be that "Show password" is false by default in NcPasswordPicker.

But for security concerns, we don't actually store the password. So when users edit an existing entry, they can set a new password, but can neither see nor edit the previously entered password.

[JuliaKirschenheuter]

Dear designers,

a kindly reminder: this is only a small a11y issue regarding error text which was not there before. We can do all improvements after certification 🙏. Do you have any considerations regarding this error text? If not, please approve this PR.

[jancborchardt]

Error text is fine, so not blocked from that side @JuliaKirschenheuter :)

[nfebe]

We can do all improvements after certification 🙏. Do you have any considerations regarding this error text? If not, please approve this PR.

@JuliaKirschenheuter please, you should track a new issue for the improvements, so we ensure it gets done. Thank you...