fix(carddav): Handle race for SAB creation better - #42052
Merged
Conversation
ChristophWurst
marked this pull request as ready for review
September 17, 2024 21:58
ChristophWurst
requested review from
miaulalala and
tcitworld
as code owners
September 17, 2024 21:58
ChristophWurst
added
3. to review
Member
|
Needs a rebase |
ChristophWurst
force-pushed
the
fix/carddav/create-sab-concurrently
branch
from
September 18, 2024 07:57
a076356 to
9ba2828
Compare
ChristophWurst
commented
Sep 18, 2024
ChristophWurst
force-pushed
the
fix/carddav/create-sab-concurrently
branch
from
September 18, 2024 08:08
9ba2828 to
0e1d12b
Compare
miaulalala
approved these changes
Sep 18, 2024
skjnldsv
approved these changes
Nov 6, 2024
skjnldsv
enabled auto-merge
November 6, 2024 08:02
* Accept non repeatable read and INSERT conflict by another read * Handle replication edge case Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
skjnldsv
force-pushed
the
fix/carddav/create-sab-concurrently
branch
from
November 6, 2024 08:13
0e1d12b to
0bb68ab
Compare
skjnldsv
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This means the code is able to handle concurrency when writing, but is (still/again) vulnerable to read/write split timing problems.
Checklist