Migrate PHP imagick module check to new SetupCheck API - #42177
Merged
Conversation
33 tasks
Contributor
Author
|
4 tasks
come-nc
force-pushed
the
feat/migrate-appdirowner-setupcheck
branch
from
January 8, 2024 16:37
b9aedfe to
3d4c4f1
Compare
come-nc
force-pushed
the
feat/migrate-imagick-setupcheck
branch
from
January 9, 2024 13:44
427e41b to
dc46b5d
Compare
come-nc
marked this pull request as ready for review
January 9, 2024 13:44
come-nc
force-pushed
the
feat/migrate-imagick-setupcheck
branch
from
January 9, 2024 13:56
dc46b5d to
3624b17
Compare
come-nc
requested review from
a team,
Altahrim,
ArtificialOwl and
nfebe
and removed request for
a team
January 9, 2024 13:57
Altahrim
approved these changes
Jan 9, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/migrate-imagick-setupcheck
branch
from
January 11, 2024 10:29
3624b17 to
d1f2add
Compare
susnux
approved these changes
Jan 11, 2024
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate PHP imagick module check to new SetupCheck API.
It is in the theming application as it was only tested when this application is enabled. I also merged the SVG support check in it to be consistent.
Checklist