fix(files): Do not add drag handlers on rename - #42242
Merged
Merged
Conversation
susnux
requested review from
ChristophWurst,
artonge,
emoral435 and
skjnldsv
December 13, 2023 15:33
Contributor
Author
|
/backport to stable28 |
susnux
force-pushed
the
fix/files-drag-when-rename-file
branch
from
December 13, 2023 15:35
db314dd to
6de9404
Compare
artonge
approved these changes
Dec 13, 2023
emoral435
approved these changes
Dec 13, 2023
emoral435
left a comment
emoral435
left a comment
Contributor
There was a problem hiding this comment.
Looked over the code and tested on dev setup - LGTM
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
emoral435
force-pushed
the
fix/files-drag-when-rename-file
branch
from
December 13, 2023 17:56
6de9404 to
9e56c78
Compare
emoral435
enabled auto-merge
December 13, 2023 17:57
emoral435
added
4. to release
Contributor
Author
|
/backport 59b9331 to stable28 |
Member
|
@susnux what about server/apps/files/src/components/FileEntryGrid.vue Lines 31 to 35 in 4db0388 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not add the drag handlers when renaming as otherwise you can not select text from the text input. So this now does not support dragging when renaming is active but this i - I think - the expected behavior.
Checklist