fix(theming): Adjust dark high contrast to fulfill WCAG 2.1 AAA contrast - #42329
Merged
Conversation
susnux
force-pushed
the
fix/dark-theme-and-element-colors
branch
from
December 16, 2023 13:11
ee63ecd to
734f0dc
Compare
susnux
force-pushed
the
fix/highcontrast
branch
from
December 16, 2023 13:13
b2ac6de to
11434aa
Compare
susnux
requested review from
JuliaKirschenheuter,
Pytal,
emoral435 and
skjnldsv
December 16, 2023 13:13
susnux
force-pushed
the
fix/dark-theme-and-element-colors
branch
from
December 16, 2023 13:49
734f0dc to
8dee78f
Compare
susnux
force-pushed
the
fix/highcontrast
branch
from
December 16, 2023 13:50
11434aa to
5296045
Compare
emoral435
force-pushed
the
fix/dark-theme-and-element-colors
branch
from
December 18, 2023 16:25
8dee78f to
ae12a73
Compare
emoral435
approved these changes
Dec 18, 2023
Contributor
Author
|
/backport to stable28 |
JuliaKirschenheuter
approved these changes
Dec 19, 2023
JuliaKirschenheuter
left a comment
Contributor
There was a problem hiding this comment.
looks great, thanks!
JuliaKirschenheuter
self-requested a review
December 19, 2023 08:54
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
fix/highcontrast
branch
from
December 19, 2023 11:10
5296045 to
81775b2
Compare
Contributor
Author
|
@JuliaKirschenheuter I adjusted all themes for the |
Contributor
That works now, thanks a lot! |
JuliaKirschenheuter
approved these changes
Dec 19, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…put border colors Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
emoral435
force-pushed
the
fix/highcontrast
branch
from
December 19, 2023 16:20
81775b2 to
acfb8ef
Compare
emoral435
enabled auto-merge
December 19, 2023 16:20
|
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Contributor
Author
|
/backport to stable28 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds high contrast support for the theming util and unit tests and adjust the high contrast dark theme to fulfill WCAG 2.1 AAA color contrast for text.
Checklist